Fix Multiple Registration Error for SQL File to Annotation Conversion Actions #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The intention action
ConvertSqlFileToAnnotationActionwas being registered multiple times for both Java/Kotlin DAO files and SQL files, causing a registration conflict error.Relation
#451
Solution
Separated the single action class into two distinct action classes to handle each file type independently:
Changes Made
Created Abstract Base Class
AbstractConvertSqlFileToAnnotationAction: Contains common logic for SQL file to annotation conversionSplit into Two Concrete Actions
ConvertSqlFileToAnnotationFromDaoAction: Handles conversion when invoked from DAO files (Java/Kotlin)ConvertSqlFileToAnnotationFromSqlAction: Handles conversion when invoked from SQL filesUpdated Plugin Configuration
plugin.xmlto register each action for its specific language contextJAVAlanguageDomaSqllanguageAdded Localized Messages
convert.sql.file.to.annotation.from.dao.*convert.sql.file.to.annotation.from.sql.*Benefits
Testing